The following document contains the results of Checkstyle .
Files | Infos | Warnings | Errors |
---|---|---|---|
10 | 0 | 0 | 289 |
Rules | Violations | Severity |
---|---|---|
PackageHtml | 2 | Error |
NewlineAtEndOfFile | 0 | Error |
Translation | 0 | Error |
JavadocMethod | 51 | Error |
JavadocType | 0 | Error |
JavadocVariable | 27 | Error |
JavadocStyle | 9 | Error |
ConstantName | 1 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 0 | Error |
RedundantImport | 0 | Error |
UnusedImports | 0 | Error |
FileLength | 0 | Error |
LineLength | 5 | Error |
MethodLength | 1 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 0 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 0 | Error |
ParenPad | 0 | Error |
TypecastParenPad | 0 | Error |
TabCharacter | 0 | Error |
WhitespaceAfter | 48 | Error |
WhitespaceAround | 0 | Error |
ModifierOrder | 1 | Error |
RedundantModifier | 0 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 0 | Error |
LeftCurly | 0 | Error |
NeedBraces | 37 | Error |
RightCurly | 27 | Error |
AvoidInlineConditionals | 11 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
HiddenField | 2 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 5 | Error |
MissingSwitchDefault | 0 | Error |
RedundantThrows | 0 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
DesignForExtension | 28 | Error |
FinalClass | 0 | Error |
HideUtilityClassConstructor | 0 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 15 | Error |
ArrayTypeStyle | 0 | Error |
FinalParameters | 17 | Error |
GenericIllegalRegexp
|
2 | Error |
TodoComment | 0 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 14 | |
Line is longer than 80 characters. | 18 | |
Method 'handle' is not designed for extension - needs to be abstract, final or empty. | 20 | |
Parameter context should be final. | 20 | |
'cast' is not followed by whitespace. | 21 | |
'cast' is not followed by whitespace. | 22 | |
'if' construct must use '{}'s. | 23 | |
'if' construct must use '{}'s. | 26 | |
'cast' is not followed by whitespace. | 28 | |
'}' should be on the same line. | 32 | |
'cast' is not followed by whitespace. | 39 | |
'}' should be on the same line. | 40 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 22 | |
Missing a Javadoc comment. | 23 | |
Missing a Javadoc comment. | 24 | |
Missing a Javadoc comment. | 25 | |
Variable 'userhours' must be private and have accessor methods. | 25 | |
Missing a Javadoc comment. | 26 | |
First sentence should end with a period. | 28 | |
Parameter db should be final. | 33 | |
Expected @param tag for 'db'. | 33 | |
Parameter rs should be final. | 33 | |
Expected @param tag for 'rs'. | 33 | |
First sentence should end with a period. | 38 | |
Parameter db should be final. | 43 | |
Expected @param tag for 'db'. | 43 | |
First sentence should end with a period. | 47 | |
Parameter db should be final. | 52 | |
Expected @param tag for 'db'. | 52 | |
Parameter record should be final. | 52 | |
Expected @param tag for 'record'. | 52 | |
Missing a Javadoc comment. | 57 | |
'if' construct must use '{}'s. | 59 | |
Missing a Javadoc comment. | 64 | |
'if' construct must use '{}'s. | 66 | |
Missing a Javadoc comment. | 71 | |
Method 'getFixedValueLeftDisplay' is not designed for extension - needs to be abstract, final or empty. | 75 | |
Missing a Javadoc comment. | 75 | |
Missing a Javadoc comment. | 79 | |
'if' construct must use '{}'s. | 81 | |
Missing a Javadoc comment. | 86 | |
'100' is a magic number. | 87 | |
Missing a Javadoc comment. | 90 | |
Method 'getSalesFeeDisplay' is not designed for extension - needs to be abstract, final or empty. | 94 | |
Missing a Javadoc comment. | 94 | |
Method 'getSalesFeeLeftDisplay' is not designed for extension - needs to be abstract, final or empty. | 98 | |
Missing a Javadoc comment. | 98 | |
Missing a Javadoc comment. | 102 | |
'if' construct must use '{}'s. | 104 | |
Missing a Javadoc comment. | 109 | |
'100' is a magic number. | 110 | |
Missing a Javadoc comment. | 113 | |
Method 'getManagementFeeDisplay' is not designed for extension - needs to be abstract, final or empty. | 117 | |
Missing a Javadoc comment. | 117 | |
Method 'getManagementFeeLeftDisplay' is not designed for extension - needs to be abstract, final or empty. | 121 | |
Missing a Javadoc comment. | 121 | |
Method 'getHoursWorkedDisplay' is not designed for extension - needs to be abstract, final or empty. | 125 | |
Missing a Javadoc comment. | 125 | |
Method 'getBudgetRemaining' is not designed for extension - needs to be abstract, final or empty. | 129 | |
Missing a Javadoc comment. | 129 | |
Method 'getBudgetRemainingPercent' is not designed for extension - needs to be abstract, final or empty. | 133 | |
Missing a Javadoc comment. | 133 | |
'if' construct must use '{}'s. | 134 | |
'100' is a magic number. | 136 | |
Missing a Javadoc comment. | 140 | |
'}' should be on the same line. | 143 | |
Method 'getHourlyRateDisplay' is not designed for extension - needs to be abstract, final or empty. | 149 | |
Missing a Javadoc comment. | 149 | |
Missing a Javadoc comment. | 153 | |
Parameter f should be final. | 153 | |
Expected an @return tag. | 160 | |
Method 'getBreakdown' is not designed for extension - needs to be abstract, final or empty. | 160 | |
Line is longer than 80 characters. | 170 | |
'}' should be on the same line. | 180 | |
'cast' is not followed by whitespace. | 182 | |
'cast' is not followed by whitespace. | 191 | |
Method 'getBudget' is not designed for extension - needs to be abstract, final or empty. | 199 | |
Missing a Javadoc comment. | 199 | |
First sentence should end with a period. | 220 | |
Line is longer than 80 characters. | 221 | |
Missing a Javadoc comment. | 224 | |
Variable 'user' must be private and have accessor methods. | 224 | |
Missing a Javadoc comment. | 225 | |
Variable 'hours' must be private and have accessor methods. | 225 | |
Missing a Javadoc comment. | 226 | |
Variable 'payment' must be private and have accessor methods. | 226 | |
Method 'getPaymentDisplay' is not designed for extension - needs to be abstract, final or empty. | 228 | |
Missing a Javadoc comment. | 228 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 26 | |
Method 'handle' is not designed for extension - needs to be abstract, final or empty. | 28 | |
Missing a Javadoc comment. | 28 | |
Parameter context should be final. | 28 | |
'cast' is not followed by whitespace. | 29 | |
'cast' is not followed by whitespace. | 30 | |
'if' construct must use '{}'s. | 31 | |
'if' construct must use '{}'s. | 34 | |
'cast' is not followed by whitespace. | 36 | |
'cast' is not followed by whitespace. | 37 | |
'cast' is not followed by whitespace. | 38 | |
'if' construct must use '{}'s. | 39 | |
'if' construct must use '{}'s. | 41 | |
'if' construct must use '{}'s. | 60 | |
'if' construct must use '{}'s. | 62 | |
'cast' is not followed by whitespace. | 75 | |
'}' should be on the same line. | 81 | |
'}' should be on the same line. | 84 | |
'}' should be on the same line. | 104 | |
'}' should be on the same line. | 108 | |
'cast' is not followed by whitespace. | 115 | |
'}' should be on the same line. | 116 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 14 | |
Line is longer than 80 characters. | 18 | |
Method 'handle' is not designed for extension - needs to be abstract, final or empty. | 20 | |
Parameter context should be final. | 20 | |
'cast' is not followed by whitespace. | 21 | |
'cast' is not followed by whitespace. | 22 | |
'if' construct must use '{}'s. | 23 | |
'cast' is not followed by whitespace. | 26 | |
'if' construct must use '{}'s. | 27 | |
'if' construct must use '{}'s. | 29 | |
'cast' is not followed by whitespace. | 31 | |
'}' should be on the same line. | 35 | |
'cast' is not followed by whitespace. | 42 | |
'}' should be on the same line. | 43 |
Violation | Message | Line |
---|---|---|
Line has trailing spaces. | 21 | |
Line has trailing spaces. | 22 | |
Missing a Javadoc comment. | 28 | |
First sentence should end with a period. | 30 | |
Variable 'connMgr' must be private and have accessor methods. | 31 | |
'static' modifier out of order with the JLS suggestions. | 34 | |
Name 'debug' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 34 | |
Expected an @return tag. | 51 | |
Method 'handle' is not designed for extension - needs to be abstract, final or empty. | 51 | |
Method length is 426 lines (max allowed is 150). | 51 | |
Parameter context should be final. | 51 | |
Expected @param tag for 'context'. | 51 | |
Expected @throws tag for 'HandlerException'. | 51 | |
'cast' is not followed by whitespace. | 65 | |
'if' construct must use '{}'s. | 66 | |
'cast' is not followed by whitespace. | 71 | |
'if' construct must use '{}'s. | 72 | |
'cast' is not followed by whitespace. | 77 | |
'if' construct must use '{}'s. | 108 | |
'}' should be on the same line. | 129 | |
'if' construct must use '{}'s. | 140 | |
'if' construct must use '{}'s. | 157 | |
'if' construct must use '{}'s. | 186 | |
Line is longer than 80 characters. | 188 | |
'if' construct must use '{}'s. | 203 | |
'}' should be on the same line. | 216 | |
'}' should be on the same line. | 229 | |
Avoid inline conditionals. | 249 | |
Avoid inline conditionals. | 250 | |
Avoid inline conditionals. | 255 | |
Avoid inline conditionals. | 263 | |
Avoid inline conditionals. | 269 | |
'}' should be on the same line. | 270 | |
'}' should be on the same line. | 288 | |
'cast' is not followed by whitespace. | 302 | |
Avoid inline conditionals. | 307 | |
'if' construct must use '{}'s. | 320 | |
'}' should be on the same line. | 322 | |
'cast' is not followed by whitespace. | 346 | |
'cast' is not followed by whitespace. | 353 | |
Avoid inline conditionals. | 358 | |
Avoid inline conditionals. | 359 | |
Avoid inline conditionals. | 361 | |
Avoid inline conditionals. | 364 | |
'if' construct must use '{}'s. | 376 | |
'}' should be on the same line. | 384 | |
'if' construct must use '{}'s. | 388 | |
'}' should be on the same line. | 393 | |
'cast' is not followed by whitespace. | 431 | |
'if' construct must use '{}'s. | 432 | |
Avoid inline conditionals. | 457 | |
',' is not followed by whitespace. | 461 | |
'cast' is not followed by whitespace. | 468 | |
'}' should be on the same line. | 469 | |
'}' should be on the same line. | 472 | |
First sentence should end with a period. | 478 | |
Expected an @return tag. | 482 | |
Parameter param should be final. | 482 | |
Expected @param tag for 'param'. | 482 | |
Parameter context should be final. | 482 | |
Expected @param tag for 'context'. | 482 | |
'cast' is not followed by whitespace. | 483 | |
'if' construct must use '{}'s. | 484 | |
'if' construct must use '{}'s. | 486 | |
First sentence should end with a period. | 491 | |
Missing a Javadoc comment. | 495 | |
Variable 'project' must be private and have accessor methods. | 495 | |
Missing a Javadoc comment. | 496 | |
Variable 'tasks' must be private and have accessor methods. | 496 | |
Missing a Javadoc comment. | 497 | |
Variable 'totalBudget' must be private and have accessor methods. | 497 | |
Missing a Javadoc comment. | 498 | |
Variable 'totalWorked' must be private and have accessor methods. | 498 | |
Method 'overBudget' is not designed for extension - needs to be abstract, final or empty. | 500 | |
Missing a Javadoc comment. | 500 | |
First sentence should end with a period. | 505 | |
Missing a Javadoc comment. | 509 | |
Variable 'task' must be private and have accessor methods. | 509 | |
Missing a Javadoc comment. | 510 | |
Variable 'tSheets' must be private and have accessor methods. | 510 | |
Missing a Javadoc comment. | 511 | |
Variable 'totalWorked' must be private and have accessor methods. | 511 | |
Method 'overBudget' is not designed for extension - needs to be abstract, final or empty. | 513 | |
Missing a Javadoc comment. | 513 | |
'if' construct must use '{}'s. | 515 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 20 | |
Method 'handle' is not designed for extension - needs to be abstract, final or empty. | 22 | |
Missing a Javadoc comment. | 22 | |
Parameter context should be final. | 22 | |
'cast' is not followed by whitespace. | 23 | |
'cast' is not followed by whitespace. | 34 | |
'if' construct must use '{}'s. | 35 | |
'cast' is not followed by whitespace. | 37 | |
'cast' is not followed by whitespace. | 43 | |
'10' is a magic number. | 47 | |
'cast' is not followed by whitespace. | 51 | |
'cast' is not followed by whitespace. | 54 | |
'}' should be on the same line. | 84 | |
'}' should be on the same line. | 90 | |
'cast' is not followed by whitespace. | 97 | |
'}' should be on the same line. | 98 |
Violation | Message | Line |
---|---|---|
Missing package documentation file. | 0 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 20 | |
Method 'handle' is not designed for extension - needs to be abstract, final or empty. | 22 | |
Missing a Javadoc comment. | 22 | |
Parameter context should be final. | 22 | |
'cast' is not followed by whitespace. | 23 | |
'cast' is not followed by whitespace. | 38 | |
'if' construct must use '{}'s. | 39 | |
'cast' is not followed by whitespace. | 42 | |
'cast' is not followed by whitespace. | 48 | |
'cast' is not followed by whitespace. | 52 | |
'if' construct must use '{}'s. | 63 | |
'10' is a magic number. | 72 | |
'}' should be on the same line. | 79 | |
'cast' is not followed by whitespace. | 86 | |
'}' should be on the same line. | 87 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 22 | |
Missing a Javadoc comment. | 23 | |
Missing a Javadoc comment. | 25 | |
Missing a Javadoc comment. | 26 | |
Variable 'id' must be private and have accessor methods. | 26 | |
Missing a Javadoc comment. | 27 | |
Variable 'db' must be private and have accessor methods. | 27 | |
Missing a Javadoc comment. | 28 | |
Variable 'connMgr' must be private and have accessor methods. | 28 | |
First sentence should end with a period. | 30 | |
Parameter db should be final. | 33 | |
'db' hides a field. | 33 | |
Expected @param tag for 'db'. | 33 | |
Parameter id should be final. | 33 | |
'id' hides a field. | 33 | |
Expected @param tag for 'id'. | 33 | |
Expected @throws tag for 'Exception'. | 33 | |
'if' construct must use '{}'s. | 36 | |
Missing a Javadoc comment. | 53 | |
Parameter id should be final. | 53 | |
Method 'getHeader' is not designed for extension - needs to be abstract, final or empty. | 59 | |
Missing a Javadoc comment. | 59 | |
Method 'getInvoiceLine' is not designed for extension - needs to be abstract, final or empty. | 63 | |
Missing a Javadoc comment. | 63 | |
Method 'getTotal' is not designed for extension - needs to be abstract, final or empty. | 67 | |
Missing a Javadoc comment. | 67 | |
'cast' is not followed by whitespace. | 70 | |
'if' construct must use '{}'s. | 72 | |
Method 'getTotalDisplay' is not designed for extension - needs to be abstract, final or empty. | 79 | |
Missing a Javadoc comment. | 79 | |
Method 'hasTimesheets' is not designed for extension - needs to be abstract, final or empty. | 83 | |
Missing a Javadoc comment. | 83 | |
Method 'write' is not designed for extension - needs to be abstract, final or empty. | 96 | |
Missing a Javadoc comment. | 96 | |
'cast' is not followed by whitespace. | 99 | |
'cast' is not followed by whitespace. | 100 | |
'cast' is not followed by whitespace. | 103 | |
'}' should be on the same line. | 112 | |
Method 'isOverdue' is not designed for extension - needs to be abstract, final or empty. | 119 | |
Missing a Javadoc comment. | 119 | |
'cast' is not followed by whitespace. | 121 | |
'cast' is not followed by whitespace. | 122 | |
'if' construct must use '{}'s. | 123 | |
'if' construct must use '{}'s. | 126 | |
Method 'isOutstanding' is not designed for extension - needs to be abstract, final or empty. | 132 | |
Missing a Javadoc comment. | 132 | |
'cast' is not followed by whitespace. | 133 |